Add docstring to InvocationCancelledError and expose to new api via exceptions.#134
Merged
Add docstring to InvocationCancelledError and expose to new api via exceptions.#134
Conversation
…xceptions. Also change from SystemExit error as this is not the corrcect error to inherit from.
Barecheck - Code coverage reportTotal: 89.19%Your code coverage diff: 0.01% ▴ Uncovered files and lines
|
julianstirling
force-pushed
the
expose-InvocationCancelledError
branch
from
7c2063d to
0c8cc73
Compare
rwb27
approved these changes
Jul 7, 2025
Collaborator
rwb27
left a comment
rwb27
left a comment
There was a problem hiding this comment.
This looks great to me. I've made a couple of minor comments, but nothing requires action and I'm happy to approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvocationCancelledError is needed for catching when invocations are cancelled but currently isn't exposed to the new API.
This also changes the exception it inherits from. I assume SystemExit was used so it bypasses
from Exceptionbecause we certainly do not want it interpreted as a full system exit. To keep this behaviour I have sub-classed it from base exception.This needs to go in with 0.0.10